Fix remoting logging DefaultAddress race condition #7305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jul 25, 2024
| @@ -189,7 +189,7 @@ public ActorPath RootPath | |||
| public Deployer Deployer { get; protected set; } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public Address DefaultAddress { get { return Transport.DefaultAddress; } } | |||
| public Address DefaultAddress { get { return Transport?.DefaultAddress; } } | |||
There was a problem hiding this comment.
Make sure we return null instead of throwing an NRE if Transport is still null.
| catch // can fail if the ActorSystem (remoting) is not completely started yet | ||
| { | ||
| return a.Path.ToString(); | ||
| } |
There was a problem hiding this comment.
Second guard to make sure that, in the event that any exception is thrown, we still return a valid actor path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7304
akka.net/src/core/Akka/Event/Logging.cs
Line 115 in 3eacb6c
This line can throw an NRE if remoting is not up and running yet
ExtendedActorSystem.Provider.DefaultAddress=>RemoteActorRefProvider.DefaultAddress=>Transport.DefaultAddress<-- Transport property is nullChanges
Make sure that we catch any NRE thrown when
Loggingtries to accessExtendedActorSystem.Provider.DefaultAddress