Akka.Actor: make ITimeProvider injectable into consuming classes
#7314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of this functionality was duplicated on the `IScheduler` anyway - so removing this makes it possible to actually inject the `ITimeProvider` into downstream dependencies using the `ActorSystem`
Aaronontheweb
commented
Aug 6, 2024
| /// <summary> | ||
| /// TBD | ||
| /// </summary> | ||
|
|
||
| public static DateTimeOffsetNowTimeProvider Instance { get; } = new(); |
There was a problem hiding this comment.
Basically, I removed all references to this type (all of which were contained inside Akka.Delivery and Akka.Cluster.Sharding.Delivery) and preferred to use the IScheduler's implementation of these same methods instead, which are identical on the HashedWheelTimer base class.
| @@ -589,6 +589,7 @@ namespace Akka.Actor | |||
| public CoordinatedShutdownExtension() { } | |||
| public override Akka.Actor.CoordinatedShutdown CreateExtension(Akka.Actor.ExtendedActorSystem system) { } | |||
| } | |||
| [System.ObsoleteAttribute("This class will be removed in Akka.NET v1.6.0 - use the IScheduler instead.")] | |||
There was a problem hiding this comment.
Marked the DateTimeNowTimeProvider as Obsolete and slated for removal in v1.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes dependencies on the static
DateTimeNowTimeProviderand instead has everything use theISchedulerinstead, which provides the exact same functionality with identical implementations. This makes it possible to inject theITimeProviderusing theActorSystem's configuration instead.This should enable us to be able to support .NET 8's
TimeProvidermore easily in the future for testing purposes.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):