Skip to content

Commit

Permalink
Revert "Provide flags to POSIX and non-POSIX scripts to prevent CDN u…
Browse files Browse the repository at this point in the history
…sage from eng/common .NET Core Install script usages (dotnet#7144)" (dotnet#7147)

This reverts commit 106356d.
  • Loading branch information
MattGal authored and akoeplinger committed Apr 12, 2021
1 parent 9927e44 commit e10ffb4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion eng/common/tools.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ function InstallDotNet([string] $dotnetRoot,
$installParameters = @{
Version = $version
InstallDir = $dotnetRoot
NoCdn = $True
}

if ($architecture) { $installParameters.Architecture = $architecture }
Expand Down
4 changes: 2 additions & 2 deletions eng/common/tools.sh
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ function InstallDotNet {
if [[ "$#" -ge "5" ]] && [[ "$5" != 'false' ]]; then
skipNonVersionedFilesArg="--skip-non-versioned-files"
fi
bash "$install_script" --no-cdn --version $version --install-dir "$root" $archArg $runtimeArg $skipNonVersionedFilesArg || {
bash "$install_script" --version $version --install-dir "$root" $archArg $runtimeArg $skipNonVersionedFilesArg || {
local exit_code=$?
echo "Failed to install dotnet SDK from public location (exit code '$exit_code')."

Expand All @@ -223,7 +223,7 @@ function InstallDotNet {
fi

if [[ -n "$runtimeSourceFeed" || -n "$runtimeSourceFeedKey" ]]; then
bash "$install_script" --no-cdn --version $version --install-dir "$root" $archArg $runtimeArg $skipNonVersionedFilesArg $runtimeSourceFeed $runtimeSourceFeedKey || {
bash "$install_script" --version $version --install-dir "$root" $archArg $runtimeArg $skipNonVersionedFilesArg $runtimeSourceFeed $runtimeSourceFeedKey || {
local exit_code=$?
Write-PipelineTelemetryError -category 'InitializeToolset' "Failed to install dotnet SDK from custom location '$runtimeSourceFeed' (exit code '$exit_code')."
ExitWithExitCode $exit_code
Expand Down

0 comments on commit e10ffb4

Please sign in to comment.