Skip to content

Commit

Permalink
Improve PipeWriterTests.CompleteWithLargeWriteThrows
Browse files Browse the repository at this point in the history
Allocate the buffer outside of the loop so we don't hit OOM issues.

While looking at the test I noticed that it actually had a bug too:
Nothing was asserting that we indeed throw an InvalidOperationException
when the writer is completed. Adding `Assert.ThrowsAsync` revealed that
the current loop iteration count was too low to hit the exception reliably
within the 10ms delay so instead check for the execution time.

Fixes dotnet#64930
  • Loading branch information
akoeplinger authored Feb 17, 2022
1 parent c1ee3cd commit c362498
Showing 1 changed file with 14 additions and 13 deletions.
27 changes: 14 additions & 13 deletions src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -228,33 +228,34 @@ public async Task WritesUsingGetMemoryWorks()
pipe.Reader.Complete();
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "allocates too much memory")]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
public async Task CompleteWithLargeWriteThrows()
{
var completeDelay = TimeSpan.FromMilliseconds(10);
var pipe = new Pipe();
pipe.Reader.Complete();

var task = Task.Run(async () =>
{
await Task.Delay(10);
await Task.Delay(completeDelay);
pipe.Writer.Complete();
});

try
// Complete while writing
await Assert.ThrowsAsync<InvalidOperationException>(async () =>
{
for (int i = 0; i < 1000; i++)
var testStartTime = DateTime.UtcNow;
var buffer = new byte[10000000];
int i = 0;
while (true)
{
var buffer = new byte[10000000];
await pipe.Writer.WriteAsync(buffer);
}
}
catch (InvalidOperationException)
{
// Complete while writing
}

await task;
// abort test if we're executing for more than 10 times the completeDelay (check every 1000th iteration)
if (i++ % 1000 == 0 && DateTime.UtcNow - testStartTime > completeDelay * 10)
break;
}
});
}

[Fact]
Expand Down

0 comments on commit c362498

Please sign in to comment.