forked from krisk/Fuse
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exports #1
Closed
Closed
Exports #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ensure that all scenarios work
With the following settings in a project that uses
fuse.js
:"type": "common"
.cjs
file extension.mjs
file extension.js
file extension"type": "module"
.cjs
file extension.mjs
file extension.js
file extension"module": "Node16", "moduleResolution": "Node16"
"type": "module"
"type": "commonjs"
fails. But this is expected behaviour because this config states that we're in a strict CJS environment, trying to use an ES module. TS doesn't know that Rollup fully compiled it down to CJS, the fix is really easy for end-users, just use"module: "CommonJS"
."module": "Node16", "moduleResolution": "Node"
"type": "module"
"type": "commonjs"
"module": "CommonJS", "moduleResolution": "Node"
"type": "module"
"type": "commonjs"