Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop backcomputing affected WFOs for VTEC #621

Merged
merged 1 commit into from
Jun 20, 2022
Merged

stop backcomputing affected WFOs for VTEC #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ segments with the same vtec action (read tropical products).
- Improved logic behind `pyiem.plot.util.pretty_bins`, it no longer exactly
returns the specified number of bins, but tries to do the right thing!
- Increase remark trimming for LSR tweets for more length safety.
- Stopped back-computing affected WFOs based on the UGCs found in a VTEC
product. This was causing more confusion than good (#615).

## **1.12.0** (18 Mar 2022)

Expand Down
5 changes: 3 additions & 2 deletions src/pyiem/nws/products/_vtec_jabber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@
def build_channels(prod, segment, vtec) -> list:
"""Build a list of channels for the given segment/vtec."""
channels = []
# Two noisey products that don't default to the main WFO channel
if prod.afos[:3] in ["MWW", "RFW"]:
channels = [f"{prod.afos[:3]}{s}" for s in prod.get_affected_wfos()]
channels.append(f"{prod.afos[:3]}{prod.source[1:]}")
else:
channels = prod.get_affected_wfos()
channels.append(prod.source[1:])
# GH604 - Append a -ACTION for CON, EXP, CAN actions
suffix = f"-{vtec.action}" if vtec.action in ["CON", "EXP", "CAN"] else ""
channels.append(f"{vtec.s2()}{suffix}")
Expand Down