-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMPORTANT: v4 beta release is ready (v3 is not supported anymore) #1974
Comments
Good news, I love you!! |
i love you. |
How do you install version 4, I'm not seeing a tag or release for it? |
It is with 'beta' tag. Latest beta for today is 4.0.0-beta.5 |
@AlmogRnD in package.json it would be:
|
Thanks this is perfect |
Master is replaced with v4 now. v3 is moved to 'v3' branch. |
Amazing Work! I have a few questions though:
Thanks |
|
@aksonov awesome. But i have one q: why mobx in dependencies? |
@dictory mobx manages navigation state and reload navigators after state changes. |
Hi off topic have you had a chance to look at my githup issue with redux
been stuck and can't move forward
…On Jul 9, 2017 23:24, "Pavel Aksonov" ***@***.***> wrote:
@dictory <https://github.com/dictory> mobx manages navigation state and
reload navigators after state changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1974 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKWI6WV67Cc7UfOZmFjIdEe2ulQCPXYks5sMcOwgaJpZM4OOgfQ>
.
|
@AlmogRnD Will do it today. |
Thanks appreciate it, getting behind
…On Jul 9, 2017 23:27, "Pavel Aksonov" ***@***.***> wrote:
@AlmogRnD <https://github.com/almogrnd> Will do it today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1974 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKWI1YiJnxYbHD5yl7PTtK9n5u4RIJRks5sMcRDgaJpZM4OOgfQ>
.
|
Beautiful! How about further drawer attributes, like drawerPosition, initialRoutename etc.? Where or how would they be declared? |
@bragur Check beta.7, you could define it as Scene props for drawer now |
My lighting talk proposal about RNRF v4 version: |
Can you explain pls the following statement:
In the API-documentation i've found nothing about it. Is the new drawer-Attribute simply a boolean setting to true when a scene is managed by a drawer? I understood, that contentCOmponent is the attribute where to pass the final Drawer-Component is it was with "drawer" in v3 |
@itinance Please check Example project to see new drawer syntax. |
I've just updated 'migration' docs about drawer. |
@aksonov I just upgraded a really simple app from v3 to v4 (4.0.0-beta.17) and navigation just stopped working (no errors or anything in the console). I checked the breaking changes and migration file but I didn't see anything that affected my app so I haven't really changed anything. Not sure how to proceed: (onPress for each song would execute this: Is there anything there that you can see offhand? Or tips to go about debugging this? Very much appreciate any help with this. |
Nm thanks, I switched to react-navigation pure |
Tell me please, what is better (v3 or v4) to use for production with redux? |
@aksonov Please provide a better documentation for v4 as in example The components Lightbox, modal are used and there is no documentation about them and also many changes in props but have nothing documented. |
how to add icon in v4 ? |
Anyone can write migration guide like webpack |
@waqas19921, @dictory Yes, v4 lacks of documentation and we are trying to improve it. Unfortunately we have lack of maintainers now. Guys, this project is open source, feel free to check sources and submit PR for docs. Guys, let's improve open source, not just use it for free. @tejacoder Check Example project and existing docs. If still not clear, create separate issue. All, I'm closing this ticket (original aim was just to make announce), create issue (and better with PRs) if any. |
Please check latest 4.0.0-beta.* , Example as demo:
https://github.com/aksonov/react-native-router-flux/tree/v4
V4 Features:
Switch
replacement) - each ‘scene’ hasonEnter
/onExit
handlers.navigationStore
(formerActions
), observe current navigation state, etc. If you are using Redux, you still could pass your reducer factory tocreateReducer
param for Router.How to customize the back button in Stack Navigator react-navigation/react-navigation#779
drawer
attribute forScene
andcontentComponent
to use your ownDrawer
)Breaking changes (comparing to v3):
No duration/panHandlers support - you have to implement custom navigator now instead and pass it as ‘navigator’ prop:
https://reactnavigation.org/docs/navigators/custom
No support for partial hiding of tab bar for some tabs because of react navigation bug:
Cannot read property 'setNativeProps' of undefined react-navigation/react-navigation#1584
No possibility to skip animation during reset/replace:
How to reset the navigation stack without animation? react-navigation/react-navigation#1493
Switch
is removed - you may useonEnter
(or juston
) /onExit
handlers for more flexible logic. They could be async functions. Success termination ofonEnter
will runsuccess
handler,failure
handler will be run otherwise. You can pass just state keys to success/failure too. This way you can create very complex state machine and don't useSwitch
or navigation from componentDidMount.getSceneStyle is removed (no needed in v4).
Custom reducer (‘createReducer prop for Router) - Redux actions now are passed from React Navigation (‘Navigation/BACK’, ‘Navigation/NAVIGATE’, etc.)
Drawer is 'drawer' attribute
Scene
Modal is 'modal' attribute for
Scene
No flux 'focus' actions - use onEnter/onExit handlers instead.
As you can see React Navigation still contains some issues, but anyway it is more stable than obsolete 'react-native-experimental-navigation' used by v3 now.
Here is link about road to v1 (so you can see all issues at one place):
react-navigation/react-navigation#723
The text was updated successfully, but these errors were encountered: