feat: add ui stage link to promo prs #2753
Conversation
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2753 +/- ##
==========================================
+ Coverage 49.38% 49.50% +0.11%
==========================================
Files 270 271 +1
Lines 19521 19666 +145
==========================================
+ Hits 9640 9735 +95
- Misses 9255 9300 +45
- Partials 626 631 +5 ☔ View full report in Codecov by Sentry. |
| Freight: *workingPromo.Status.FreightCollection.DeepCopy(), | ||
| StartFromStep: promo.Status.CurrentStep, | ||
| State: directives.State(workingPromo.Status.GetState()), | ||
| APIServerBaseURL: r.cfg.APIServerBaseURL, |
There was a problem hiding this comment.
Nit (and non-blocking): this should probably become part of a nested something at some point. As its placement feels odd as-is.
There was a problem hiding this comment.
Second nit: from the perspective of what we use it for now (within the context of directives), isn't this just the UIBaseURL?
There was a problem hiding this comment.
Fair point. I'll change that.
There was a problem hiding this comment.
this should probably become part of a nested something at some point
This part, I'll save for another day, because I cannot quite figure out yet what other things it ought to be grouped with.
Fixes #1825