Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(backport release-1.0): fix(build): use tini to reap zombie processes #2960

Merged
merged 2 commits into from
Dec 2, 2024
Merged

chore(backport release-1.0): fix(build): use tini to reap zombie processes #2960

merged 2 commits into from
Dec 2, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Nov 19, 2024

Manual backport of #2959 due to conflicts.

@hiddeco
fix(build): use tini to reap zombie processes (akuity#2959)
2c53d0c 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
(cherry picked from commit 34c6128)
@hiddeco hiddeco added kind/bug priority/high area/charts docker Pull requests that update Docker code labels Nov 19, 2024
@hiddeco hiddeco added this to the v1.0.4 milestone Nov 19, 2024
@hiddeco hiddeco self-assigned this Nov 19, 2024
@hiddeco hiddeco requested a review from a team as a code owner November 19, 2024 00:02
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 351ecf1
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/674d687ea880be0008bf75da
😎 Deploy Preview https://deploy-preview-2960.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiddeco hiddeco enabled auto-merge (squash) November 19, 2024 00:02
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.80%. Comparing base (a425864) to head (351ecf1).
Report is 1 commits behind head on release-1.0.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.0    #2960   +/-   ##
============================================
  Coverage        48.80%   48.80%           
============================================
  Files              270      270           
  Lines            23966    23966           
============================================
  Hits             11696    11696           
  Misses           11638    11638           
  Partials           632      632

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krancour
krancour approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Not sure how this PR escaped my attention for so long. LGTM

@hiddeco hiddeco merged commit 3972ee9 into akuity:release-1.0 Dec 2, 2024
17 checks passed
@hiddeco hiddeco deleted the backport-2959-to-release-1.0 branch December 2, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour approved these changes

Assignees

@hiddeco hiddeco

Labels
area/charts docker Pull requests that update Docker code kind/bug priority/high
Projects
None yet
Milestone
v1.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@hiddeco @krancour @fykaa