Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): manual backport of git-clone fix from #3012 #3019

Merged

Conversation

krancour
Copy link
Member

@krancour krancour commented Nov 27, 2024

Manual backport of #3012

Merge conflicts prevented an automated backport.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this to the v1.0.4 milestone Nov 27, 2024
@krancour krancour self-assigned this Nov 27, 2024
@krancour krancour requested a review from a team as a code owner November 27, 2024 22:09
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 493bb10
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/674798a626f66200083d64f1
😎 Deploy Preview https://deploy-preview-3019.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour changed the title fix(controller): manual backport of git-clone fix from # fix(controller): manual backport of git-clone fix from #3012 Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 48.80%. Comparing base (831c348) to head (493bb10).
Report is 1 commits behind head on release-1.0.

Files with missing lines Patch % Lines
internal/directives/git_cloner.go 9.09% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0    #3019      +/-   ##
===============================================
- Coverage        48.82%   48.80%   -0.02%     
===============================================
  Files              270      270              
  Lines            23957    23966       +9     
===============================================
  Hits             11696    11696              
- Misses           11630    11638       +8     
- Partials           631      632       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco merged commit a425864 into akuity:release-1.0 Nov 28, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants