forked from actions/setup-dotnet
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor installer #15
Closed
Closed
+472
−450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2023
dsame
approved these changes
May 25, 2023
MaksimZhukov
approved these changes
May 30, 2023
nikolai-laevskii
force-pushed
the
refactor-installer
branch
from
May 31, 2023 09:20
ee918ff
to
3cdb094
Compare
IvanZosimov
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactoring was conducted only for installer.ts module. The most significant changes are in
DotnetCoreInstaller
class:DotnetInstallDir
classDotnetInstallScript
class, which now allows to invoke install-script multiple times and conditionally apply script arguments.Example of
DotnetInstallScript
class usage (just an example code, not how it is actually set here)The script preparation is conducted upon calling the constructor and all platform-specific arguments are inserted by default
Related issue:
Related but does not solve actions#387, just conducts necessary preparations for further fix. Should be treated as general refactoring.
Check list: