Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader/service: use class name as the service name #18

Closed
wants to merge 1 commit into from

Conversation

DuanPengfei
Copy link
Collaborator

Use class name as the service name when load service.

Fixes: #17

Use class name as the service name when load serice.
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

XadillaX pushed a commit that referenced this pull request Jul 5, 2017
Use class name as the service name when load serice.

PR-URL: #18
Reviewed-By: XadillaX <i@2333.moe>
@XadillaX
Copy link
Contributor

XadillaX commented Jul 5, 2017

Landed in c232d61

@XadillaX XadillaX closed this Jul 5, 2017
XadillaX pushed a commit that referenced this pull request Jul 5, 2017
Use class name as the service name when load serice.

PR-URL: #18
Reviewed-By: XadillaX <i@2333.moe>
@XadillaX XadillaX mentioned this pull request Jul 5, 2017
XadillaX pushed a commit that referenced this pull request Jul 6, 2017
Use class name as the service name when load serice.

PR-URL: #18
Reviewed-By: XadillaX <i@2333.moe>
@XadillaX XadillaX mentioned this pull request Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants