Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add issue and pull request templates #22

Closed
wants to merge 1 commit into from

Conversation

XadillaX
Copy link
Contributor

@XadillaX XadillaX commented Jul 5, 2017

Refs: nodejs/node#5291

Checklist
Affected core submodule(s)

@XadillaX XadillaX added the meta label Jul 5, 2017
@XadillaX XadillaX force-pushed the feature/contributing branch from 4b4e73a to c6a3004 Compare July 5, 2017 08:51

This issue tracker is for bugs and issues found within Akyuu.js core.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了空行?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是照着 Node.js 来的。

Copy link
Contributor

@xiaoqiangsdl xiaoqiangsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sallen450 pushed a commit that referenced this pull request Jul 6, 2017
Refs: nodejs/node#5291
PR-URL: #22
Reviewed-By: Chengqiang Chen <602196490@qq.com>
Reviewed-By: Cleverboy32 <wyzhdu@163.com>
@sallen450
Copy link
Collaborator

Landed in 8559ae4

@sallen450 sallen450 closed this Jul 6, 2017
XadillaX added a commit that referenced this pull request Jul 6, 2017
Refs: nodejs/node#5291
PR-URL: #22
Reviewed-By: Chengqiang Chen <602196490@qq.com>
Reviewed-By: Cleverboy32 <wyzhdu@163.com>
@XadillaX XadillaX mentioned this pull request Jul 6, 2017
XadillaX added a commit that referenced this pull request Jul 6, 2017
Refs: nodejs/node#5291
PR-URL: #22
Reviewed-By: Chengqiang Chen <602196490@qq.com>
Reviewed-By: Cleverboy32 <wyzhdu@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants