Skip to content

Commit

Permalink
Merge branch 'net-mii-clause-37-helpers'
Browse files Browse the repository at this point in the history
Russell King says:

====================
net: mii clause 37 helpers

This is a re-post of two patches that are common to two series that
I've sent in recent weeks; I'm re-posting them separately in the hope
that they can be merged.  No changes from either of the previous
postings.

These patches:

1. convert the existing (unused) mii_lpa_to_ethtool_lpa_x() function
   to a linkmode variant.

2. add a helper for clause 37 advertisements, supporting both the
   1000baseX and defacto 2500baseX variants. Note that ethtool does
   not support half duplex for either of these, and we make no effort
   to do so.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
davem330 committed Mar 16, 2020
2 parents 5d0ab06 + a9f28eb commit 3c04d35
Showing 1 changed file with 39 additions and 18 deletions.
57 changes: 39 additions & 18 deletions include/linux/mii.h
Original file line number Diff line number Diff line change
Expand Up @@ -354,24 +354,6 @@ static inline u32 mii_adv_to_ethtool_adv_x(u32 adv)
return result;
}

/**
* mii_lpa_to_ethtool_lpa_x
* @adv: value of the MII_LPA register
*
* A small helper function that translates MII_LPA
* bits, when in 1000Base-X mode, to ethtool
* LP advertisement settings.
*/
static inline u32 mii_lpa_to_ethtool_lpa_x(u32 lpa)
{
u32 result = 0;

if (lpa & LPA_LPACK)
result |= ADVERTISED_Autoneg;

return result | mii_adv_to_ethtool_adv_x(lpa);
}

/**
* mii_lpa_mod_linkmode_adv_sgmii
* @lp_advertising: pointer to destination link mode.
Expand Down Expand Up @@ -535,6 +517,45 @@ static inline u32 linkmode_adv_to_lcl_adv_t(unsigned long *advertising)
return lcl_adv;
}

/**
* mii_lpa_mod_linkmode_x - decode the link partner's config_reg to linkmodes
* @linkmodes: link modes array
* @lpa: config_reg word from link partner
* @fd_bit: link mode for 1000XFULL bit
*/
static inline void mii_lpa_mod_linkmode_x(unsigned long *linkmodes, u16 lpa,
int fd_bit)
{
linkmode_mod_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, linkmodes,
lpa & LPA_LPACK);
linkmode_mod_bit(ETHTOOL_LINK_MODE_Pause_BIT, linkmodes,
lpa & LPA_1000XPAUSE);
linkmode_mod_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, linkmodes,
lpa & LPA_1000XPAUSE_ASYM);
linkmode_mod_bit(fd_bit, linkmodes,
lpa & LPA_1000XFULL);
}

/**
* linkmode_adv_to_mii_adv_x - encode a linkmode to config_reg
* @linkmodes: linkmodes
* @fd_bit: full duplex bit
*/
static inline u16 linkmode_adv_to_mii_adv_x(const unsigned long *linkmodes,
int fd_bit)
{
u16 adv = 0;

if (linkmode_test_bit(fd_bit, linkmodes))
adv |= ADVERTISE_1000XFULL;
if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT, linkmodes))
adv |= ADVERTISE_1000XPAUSE;
if (linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, linkmodes))
adv |= ADVERTISE_1000XPSE_ASYM;

return adv;
}

/**
* mii_advertise_flowctrl - get flow control advertisement flags
* @cap: Flow control capabilities (FLOW_CTRL_RX, FLOW_CTRL_TX or both)
Expand Down

0 comments on commit 3c04d35

Please sign in to comment.