Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all old API arguments and replaced with an object of parameters. (Closes #77) #101

Merged
merged 2 commits into from
Jun 19, 2017
Merged

Conversation

alallier
Copy link
Owner

@alallier alallier commented Jun 19, 2017

  • Updated README with API changes
  • Updated sample app

(Closes #77)

* Updated README with API changes
* Updated sample app
@alallier alallier added this to the v2.0.0 milestone Jun 19, 2017
@alallier alallier changed the title Removed all old API arguments and replaced with an object of parameters. Removed all old API arguments and replaced with an object of parameters. (Closes #77) Jun 19, 2017
@ghost
Copy link

ghost commented Jun 19, 2017

I was just going to fix that

@alallier
Copy link
Owner Author

@Yamboy1 please try and give a heads up on what you want to work on in the issues, so that way you can see if myself or anyone else is working on the issue at hand. This is to save you or anyone else time that are working on the issues and avoid possible double work on the same issue.

@ghost
Copy link

ghost commented Jun 19, 2017

Ok

@alallier
Copy link
Owner Author

@Yamboy1 no worries though I love your enthusiasm on the project.

@alallier
Copy link
Owner Author

Going to merge since this is going into the v2 branch. Additional testing will be ran again to ensure everything is working as intended before v2 goes into master.

@alallier alallier merged commit 04f0deb into alallier:v2.0.0 Jun 19, 2017
@alallier alallier deleted the objectParams branch June 19, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant