Add support for port 443 #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@superhawk610 Does this look okay? |
|
I don't have access to a HTTPS server to test but the logic looks sound, assuming 443 is an anonymous port and behaves the same way as 80. Edit: Confirmed command returns without port whether specifying port 443 or not |
superhawk610
approved these changes
Jul 13, 2017
ghost
mentioned this pull request
|
I was thinking about this PR. It shouldn't be needed after thinking about it. When using reload in command line mode we only create a |
|
Closing due to @alallier's comment |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A modified version of @superhawk610's Pull Request #128 that automatically adds
:443if ahttpsis used rather that ahttp.