Add Node 14.x and remove 13.x to GitHub Action CI Testing #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 131 131
=========================================
Hits 131 131 Continue to review full report at Codecov.
|
kethinov
reviewed
May 25, 2020
.github/workflows/ci.yml
Outdated
| @@ -5,7 +5,7 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| node-version: [10.x, 12.x, 13.x] | |||
| node-version: [10.x, 12.x, 13.x, 14.x] | |||
There was a problem hiding this comment.
Any reason to keep 13 around?
There was a problem hiding this comment.
Yeah thanks for pointing this out, made me look up the version. It's EOL on June 1st, 2020. Going to nix it
alallier
force-pushed
the
updateActionsFor14
branch
from
4913fec
to
6eab1ee
Compare
alallier
changed the title
alallier
added a commit
that referenced
this pull request
May 25, 2020
------------------ * Fixed bug where command line Reload where reload was writing to a file properly that broke on Node 14.x - See: #245 * GitHub Actions - See: #247 * Added Node 14.x to GitHub Actions CI * Removed Node 13.x from GitHub Actions due to end of life * Dependency Updates * Updated codecov from 3.6.1 to 3.7.0 - See: #235 and #246 * Updated commander from 4.1.0 to 5.1.0 - See: #246 * Updated minimist from 1.2.0 to 1.2.3 (Security package-lock.json) - See: #236 * Updated mocha from 7.0.0 to 7.1.2 - See: #233 * Updated sinon from 8.0.4 to 9.0.2 - See: #231 and #234 * Updated standard from 14.3.1 to 14.3.4 - See: #238 * Updated nyc from 15.0.0 to 15.0.1 - See: #242 * Updated ws from 7.2.0 to 7.3.0 - See: #244
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.