Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed HTTP server error and auto increment port in command line 256 & 239. #262

Closed
wants to merge 1 commit into from

Conversation

vineethbc
Copy link

The http server error is being handled gracefully with error message & reload increments the port & tries again.
#256
#239

The http server error is being handled gracefully with error message & reload increments the port & tries again.
#256
#239
@alallier alallier changed the title Fix for issues 256 & 239. Fixed HTTP server error and auto increment port in command line 256 & 239. Sep 29, 2020
Copy link
Owner

@alallier alallier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, just one feedback/action item

console.log('monitoring dir ' + clc.green.bold(program.dir))

supervisor.child.on('exit', function () {
program.port++
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an on by default flag option for the auto increment?

@porst17
Copy link
Contributor

porst17 commented Dec 10, 2020

Any chance for this being merged soon?

I created something like this in porst17@549e4fb using the portfinder package, not being aware of the work done in this pull request.

But having a solution like yours that doesn't add another dependency is probably preferable.

@alallier
Copy link
Owner

@porst17 I have this basically done and re-worked in a separate branch. I should be able to get this up soon.

@vineethbc vineethbc closed this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants