Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0 #41

Merged
merged 4 commits into from
Jun 24, 2016
Merged

Version 1.0.0 #41

merged 4 commits into from
Jun 24, 2016

Conversation

alallier
Copy link
Owner

Version 1.0.0

Vastly improves and removes a lot of complexities that caused bugs and misuse of reload.

Added

  • Two new badges to the README (code-style and npm version)
  • Verbose mode as option for both Express and command line usage
  • A sample app for express

Modified

  • Re-wrote the README to reflect all of these changes
  • Updated dependencies to their latest version’s
  • Fixed race condition that caused reload to spam the server when using sockets for automatic reloading.

Removed

  • All delays (wait, normal, and socket) (Reload is now all automatic using web sockets (no delays at all))
  • Client side sockjs web sockets (removed sockjs) (Now using native web sockets on the client side and ws on server side)

, reload = require('reload')
, bodyParser = require('body-parser')
, logger = require('morgan')
http = require('http')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to fix this to comply with standard.


// Wait until the page loads for the first time and then call the webSocketWaiter function so that we can connect the socket for the first time
window.addEventListener('load', function () {
if (verboseLogging === true) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can change this to if (verboseLogging).

@alallier
Copy link
Owner Author

Updated based on your requests

@alallier alallier merged commit dc85d3a into alallier:master Jun 24, 2016
@alallier alallier deleted the version1.0.0 branch June 24, 2016 13:56
@alallier alallier mentioned this pull request Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants