Support WSS when running a HTTPS server #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will convert `http://` -> `ws://` and `https://` -> `wss://`.
jprichardson
reviewed
Nov 4, 2016
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "reload", | |||
| "version": "1.0.2", | |||
| "version": "1.0.3", | |||
There was a problem hiding this comment.
Please stop incrementing the version number.
There was a problem hiding this comment.
Sure, no problem.
I thought when you said "squash" you were referring to git squash... https://davidwalsh.name/squash-commits-git.
I guess you meant not to increment the version. If you want both it isn't really clear what you want. I guess that is what this is for. #51
There was a problem hiding this comment.
I can see the confusion @coderfin, no worries. I will get to merging this really soon (hopefully today).
|
Looks great thank you for this! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will convert
http://->ws://andhttps://->wss://.