Feature: Import readability.js from npm #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure we get the latest version of readability.js whenever the user installs ReadabiliPy.
This is a little strange. I had a failing test after replacing the readability.js version, but looking at the expected output it seems that this wasn't actually correct. There were a significant number of repeated paragraphs, which this commit fixes. Also I think the output of Readability may have changed somehow, because extract_text_blocks_as_plain_text wasn't giving the correct output. I think this commit fixes both issues.
This was referenced Mar 27, 2021
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need to hard-code Readability.js in the package and instead simply imports it from NPM. This will ensure that the user gets the most recent improvements in readability.js whenever they install ReadabiliPy.
I believe this also solves #92.