Properly handle optional arrow params without type annotations #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387
I reworked
typedParseConditional
significantly from the Babel implementationand didn't realize that I needed to preserve bare
?
tokens to denote theparameter optional. Fortunately, the optional case will always be
?,
or?)
(an initializer isn't allowed when the param is optional), and neither of those
cases is valid as the start of a ternary, so we can distinguish optional param
from ternary with only one token of lookahead.