Add support for parsing declare TS class fields
#537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #536 We already completely remove uninitialized class fields for now, which agrees with the `declare` behavior, so the only change needed here was to parse the syntax without crashing. In the future, when we remove the class fields transform, we'll need to distinguish declare vs non-declare fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #536
We already completely remove uninitialized class fields for now, which agrees
with the
declarebehavior, so the only change needed here was to parse thesyntax without crashing. In the future, when we remove the class fields
transform, we'll need to distinguish declare vs non-declare fields.