Fix regression causing incomplete nullish coalesce in some cases #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #609 The original implementation of the Jest transform (#540) needed to remove regions of code, but ran into issues with the optional chaining and nullish coalescing transforms, since those transforms would still emit function calls around tokens even if they were removed. The implementation fixed those issues by disabling the optional chaining and nullish coalescing code emit in `removeToken` and `removeInitialToken`. Unfortunately, this broke other cases, like a nullish coalescing call immediately followed by a type token. The nullish coalescing implementation expected `appendTokenSuffix` to be called on the last token even though it was a type token. The changes to `TokenProcessor` actually became unnecessary as of #608 since we no longer are deleting a region of code, so I reverted the two methods back to their original implementation, which fixes the issue.
Codecov Report
@@ Coverage Diff @@
## main #610 +/- ##
==========================================
- Coverage 82.04% 82.03% -0.01%
==========================================
Files 56 56
Lines 5620 5618 -2
Branches 1320 1320
==========================================
- Hits 4611 4609 -2
Misses 725 725
Partials 284 284
Continue to review full report at Codecov.
|
Benchmark resultsBefore this PR: 265.7 thousand lines per second Measured change: 1.33% slower (2.73% slower to 3.58% faster) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #609
The original implementation of the Jest transform (#540) needed to remove
regions of code, but ran into issues with the optional chaining and nullish
coalescing transforms, since those transforms would still emit function calls
around tokens even if they were removed. The implementation fixed those issues
by disabling the optional chaining and nullish coalescing code emit in
removeTokenandremoveInitialToken. Unfortunately, this broke other cases,like a nullish coalescing call immediately followed by a type token. The nullish
coalescing implementation expected
appendTokenSuffixto be called on the lasttoken even though it was a type token.
The changes to
TokenProcessoractually became unnecessary as of #608 since weno longer are deleting a region of code, so I reverted the two methods back to
their original implementation, which fixes the issue.