Port babel-parser changes from 2022-05-01 to 2022-06-27 #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser 0e6900d771 Fix parsing ts type casts and nested patterns in destructuring (#14500) π« It looks like this only affects AST transformation and error handling, so not relevant for Sucrase. e29e915d2e fix: allow liberal named type-as imports (#14522) β Sucrase already had looser checking and is not affected, but I added a test anyway. 47a3240c39 v7.17.12 π« Release only. 9156230e68 Fix parsing of `<` after object literals with the `jsx` plugin (#14557) π« Sucrase isn't affected by this issue, seems to be a bug in Babel implementation details that were removed for Sucrase. d6ff91940f [ts] Add support for instantiation expressions (#14457) β Implemented by adding back the startsExpr flag on tokens and filling it in based on Babel's definitions. Used updated logic from 2ca44e4951 below. Also implemented typeof and new cases similarly to Babel. 59d24a45d9 [ts 4.7] Support `extends` constraints for `infer` (#14476) β Implemented using logic similar to Babel and TS. Sadly, this requires adding a new state field, which slows down all snapshot/restore and adds some extra work to all type parsing. 6415f091ff [ts 4.7] Support optional variance annotations (#14359) β Implemented more directly without using the modifiers system, which didn't seem necessary here. 2d5f5ad7fd v7.18.0 π« Release only. f8cf03c067 Fix typo in moduleAttributesVerionPluginOption (#14584) π« Typo not in Sucrase. 4d4db2a95b v7.18.3 π« Relase only. 8967ccbdd8 fix: `loc.index` of some nodes is wrongly enumerable. (#14595) π« AST only. e8c4b78330 [ts] FIx parsing of nested `extends` type in arrow type (#14604) β Set inDisallowConditionalTypesContext for that code path and added test. 64b30c673e Update failing Babel 8 parser fixture (#14615) π« Babel internal change. 5419d84da4 v7.18.4 π« Release only. 52cdab724d [babel 8] Recover from error when parsing `<T>() => {}</T>` (#14616) π« Appears to only affect error handling. dd75b027e4 feat: Automatically generate test results that do not exist (#14592) π« Babel internal change. 3b206e11a7 Enable test `variance-annotations-with-jsx` with babel8 (#14626) π« Babel internal change. 352d4d2246 v7.18.5 π« Release only. f8785e973b Rename Babel parser decorator tests (#14665) π« Babel internal change. 2ca44e4951 [ts] Allow `...<...>` followed by newline or binary operator (#14636) β Implemented with same logic as Babel. f0ec180eb7 Enforce `_foo.default || _foo` to import lib files in tests (#14673) π« Babel internal change. 4c3365f6bd Enforce setting `type` in `package.json` (#14675) π« Babel internal change. e8dce41083 JSON modules should be imported with default (#14668) π« Only affects validation, so not relevant for Sucrase. e4e700ebe5 [ts] Disallow property access after instantiation expression (#14650) π« Only affects validation, so not relevant for Sucrase. 7c91b80f31 v7.18.6 π« Release only.
Codecov Report
@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 86.86% 87.03% +0.16%
==========================================
Files 54 54
Lines 5665 5700 +35
Branches 1333 1341 +8
==========================================
+ Hits 4921 4961 +40
+ Misses 472 470 -2
+ Partials 272 269 -3
π£ Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Benchmark resultsBefore this PR: 319.1 thousand lines per second Measured change: 1.29% slower (1.91% slower to 0.79% faster) |
1Lighty
pushed a commit
to Astra-mod/sucrase
that referenced
this pull request
Aug 14, 2022
) Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser 0e6900d771 Fix parsing ts type casts and nested patterns in destructuring (#14500) π« It looks like this only affects AST transformation and error handling, so not relevant for Sucrase. e29e915d2e fix: allow liberal named type-as imports (#14522) β Sucrase already had looser checking and is not affected, but I added a test anyway. 47a3240c39 v7.17.12 π« Release only. 9156230e68 Fix parsing of `<` after object literals with the `jsx` plugin (#14557) π« Sucrase isn't affected by this issue, seems to be a bug in Babel implementation details that were removed for Sucrase. d6ff91940f [ts] Add support for instantiation expressions (#14457) β Implemented by adding back the startsExpr flag on tokens and filling it in based on Babel's definitions. Used updated logic from 2ca44e4951 below. Also implemented typeof and new cases similarly to Babel. 59d24a45d9 [ts 4.7] Support `extends` constraints for `infer` (#14476) β Implemented using logic similar to Babel and TS. Sadly, this requires adding a new state field, which slows down all snapshot/restore and adds some extra work to all type parsing. 6415f091ff [ts 4.7] Support optional variance annotations (#14359) β Implemented more directly without using the modifiers system, which didn't seem necessary here. 2d5f5ad7fd v7.18.0 π« Release only. f8cf03c067 Fix typo in moduleAttributesVerionPluginOption (#14584) π« Typo not in Sucrase. 4d4db2a95b v7.18.3 π« Relase only. 8967ccbdd8 fix: `loc.index` of some nodes is wrongly enumerable. (#14595) π« AST only. e8c4b78330 [ts] FIx parsing of nested `extends` type in arrow type (#14604) β Set inDisallowConditionalTypesContext for that code path and added test. 64b30c673e Update failing Babel 8 parser fixture (#14615) π« Babel internal change. 5419d84da4 v7.18.4 π« Release only. 52cdab724d [babel 8] Recover from error when parsing `<T>() => {}</T>` (#14616) π« Appears to only affect error handling. dd75b027e4 feat: Automatically generate test results that do not exist (#14592) π« Babel internal change. 3b206e11a7 Enable test `variance-annotations-with-jsx` with babel8 (#14626) π« Babel internal change. 352d4d2246 v7.18.5 π« Release only. f8785e973b Rename Babel parser decorator tests (#14665) π« Babel internal change. 2ca44e4951 [ts] Allow `...<...>` followed by newline or binary operator (#14636) β Implemented with same logic as Babel. f0ec180eb7 Enforce `_foo.default || _foo` to import lib files in tests (#14673) π« Babel internal change. 4c3365f6bd Enforce setting `type` in `package.json` (#14675) π« Babel internal change. e8dce41083 JSON modules should be imported with default (#14668) π« Only affects validation, so not relevant for Sucrase. e4e700ebe5 [ts] Disallow property access after instantiation expression (#14650) π« Only affects validation, so not relevant for Sucrase. 7c91b80f31 v7.18.6 π« Release only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser
0e6900d771 Fix parsing ts type casts and nested patterns in destructuring (#14500)
π« It looks like this only affects AST transformation and error handling, so not relevant for Sucrase.
e29e915d2e fix: allow liberal named type-as imports (#14522)
β Sucrase already had looser checking and is not affected, but I added a test anyway.
47a3240c39 v7.17.12
π« Release only.
9156230e68 Fix parsing of
<after object literals with thejsxplugin (#14557)π« Sucrase isn't affected by this issue, seems to be a bug in Babel implementation details that were removed for Sucrase.
d6ff91940f [ts] Add support for instantiation expressions (#14457)
β Implemented by adding back the startsExpr flag on tokens and filling it in based on Babel's definitions. Used updated logic from 2ca44e4951 below. Also implemented typeof and new cases similarly to Babel.
59d24a45d9 [ts 4.7] Support
extendsconstraints forinfer(#14476)β Implemented using logic similar to Babel and TS. Sadly, this requires adding a new state field, which slows down all snapshot/restore and adds some extra work to all type parsing.
6415f091ff [ts 4.7] Support optional variance annotations (#14359)
β Implemented more directly without using the modifiers system, which didn't seem necessary here.
2d5f5ad7fd v7.18.0
π« Release only.
f8cf03c067 Fix typo in moduleAttributesVerionPluginOption (#14584)
π« Typo not in Sucrase.
4d4db2a95b v7.18.3
π« Relase only.
8967ccbdd8 fix:
loc.indexof some nodes is wrongly enumerable. (#14595)π« AST only.
e8c4b78330 [ts] FIx parsing of nested
extendstype in arrow type (#14604)β Set inDisallowConditionalTypesContext for that code path and added test.
64b30c673e Update failing Babel 8 parser fixture (#14615)
π« Babel internal change.
5419d84da4 v7.18.4
π« Release only.
52cdab724d [babel 8] Recover from error when parsing
<T>() => {}</T>(#14616)π« Appears to only affect error handling.
dd75b027e4 feat: Automatically generate test results that do not exist (#14592)
π« Babel internal change.
3b206e11a7 Enable test
variance-annotations-with-jsxwith babel8 (#14626)π« Babel internal change.
352d4d2246 v7.18.5
π« Release only.
f8785e973b Rename Babel parser decorator tests (#14665)
π« Babel internal change.
2ca44e4951 [ts] Allow
...<...>followed by newline or binary operator (#14636)β Implemented with same logic as Babel.
f0ec180eb7 Enforce
_foo.default || _footo import lib files in tests (#14673)π« Babel internal change.
4c3365f6bd Enforce setting
typeinpackage.json(#14675)π« Babel internal change.
e8dce41083 JSON modules should be imported with default (#14668)
π« Only affects validation, so not relevant for Sucrase.
e4e700ebe5 [ts] Disallow property access after instantiation expression (#14650)
π« Only affects validation, so not relevant for Sucrase.
7c91b80f31 v7.18.6
π« Release only.