Fix broken error messages in Jest integration #750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source-map-support library was using a simple regex-based approach to detect the sourceMappingURL string in files, and it had a false positive on the integration file itself. This meant that any crash was showing a JSON parsing error rather on the invalid source map rather than the actual error.
To fix, I hacked the code to build the snippet across two strings. This now shows correct error validation when you have a syntax error or a mistake in your Sucrase configuration, for example.