[core] Refresh the 'AmInterested' status regularly #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several cases where the 'AmInterested' status can change for a given peer, and it's not easy to provide an event for each of these. For example, the 'interested' status is dependent on each bitfield added as an 'IgnoringBitfield' to the piecepicker. These bitfields can change arbitrarily. This async check will ensure that things will refresh regularly. As updating the priority of a file does have a pretty clear user action associated with it, special case this to cause an immediate refresh of the 'AmInterested' status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several cases where the 'AmInterested' status can change for a given peer, and it's not easy to provide an event for each of these.
For example, the 'interested' status is dependent on each bitfield added as an 'IgnoringBitfield' to the piecepicker. These bitfields can change arbitrarily. This async check will ensure that things will refresh regularly.
As updating the priority of a file does have a pretty clear user action associated with it, special case this to cause an immediate refresh of the 'AmInterested' status.
Fixes #597