Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: convert to typescript #21

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

achingbrain
Copy link
Collaborator

@achingbrain achingbrain commented Feb 21, 2024

  • Converts to typescript
  • Only named exports
  • No more CJS, only ESM
  • Uses aegir for building/testing/publishing
  • Publishes with provenance
  • Publishes API docs to gh-pages branch
  • Switches travis for GitHub CI
  • Updates deps

Similar in scope to alanshaw/it-ws#6 etc

- Converts to typescript
- Only named exports
- No more CJS, only ESM
- Uses aegir for building/testing/publishing
- Publishes with provenance
- Publishes API docs
- Switches travis for GitHub CI
- Updates deps

Similar in scope to alanshaw/it-ws#6 etc
@achingbrain
Copy link
Collaborator Author

CI hasn't run here because I can't push branches to this repo so the PR comes from a fork..

Copy link
Owner

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -12,7 +12,7 @@
const fs = require('fs')
const os = require('os')
const toIterable = require('../')
const pipe = require('it-pipe')
import { pipe } from 'it-pipe'
Copy link
Owner

@alanshaw alanshaw Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some more love? i.e. convert the requires

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@alanshaw alanshaw merged commit afedf8b into alanshaw:master Mar 7, 2024
@achingbrain achingbrain deleted the feat/convert-to-typescript branch March 8, 2024 05:48
achingbrain added a commit to achingbrain/stream-to-it that referenced this pull request Mar 8, 2024
Fixes errors introduced during alanshaw#21
achingbrain added a commit to achingbrain/stream-to-it that referenced this pull request Mar 8, 2024
Fixes errors introduced during alanshaw#21
achingbrain added a commit to achingbrain/stream-to-it that referenced this pull request Mar 8, 2024
Fixes errors introduced during alanshaw#21
achingbrain added a commit to achingbrain/stream-to-it that referenced this pull request Mar 8, 2024
Fixes errors introduced during alanshaw#21
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
## [1.0.0](v0.2.4...v1.0.0) (2024-04-08)

### ⚠ BREAKING CHANGES

* convert to typescript (#21)

### Features

* convert to typescript ([#21](#21)) ([afedf8b](afedf8b))

### Bug Fixes

* fix types and linting ([#22](#22)) ([ceae18f](ceae18f))
* update repo paths in package.json ([#23](#23)) ([059ccc5](059ccc5))
Copy link

github-actions bot commented Apr 8, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants