Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support password protected keys. #661

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Support password protected keys. #661

merged 2 commits into from
Mar 31, 2021

Conversation

FakeTeam
Copy link

@FakeTeam FakeTeam commented Mar 26, 2021

Provide an interface that supports password-protected keys.

Fixed #653

Copy link

@evorw evorw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! A few issues in the comment block:

  • Set the passwrod of key in PEM format.
  • \param [in,out] self An SSL/TLS socket object.
  • \param [in] passwdw The passwrod of key in PEM format.
  • \since v0.9.0
    Typos: passwrod, passwdw, passwrod. And the since version number is wrong.

@FakeTeam
Copy link
Author

Nice change! A few issues in the comment block:

  • Set the passwrod of key in PEM format.
  • \param [in,out] self An SSL/TLS socket object.
  • \param [in] passwdw The passwrod of key in PEM format.
  • \since v0.9.0
    Typos: passwrod, passwdw, passwrod. And the since version number is wrong.

Thank you, I will correct the typos. Can you tell me the correct version number?

@alanxz alanxz merged commit dd2f764 into alanxz:master Mar 31, 2021
@alanxz
Copy link
Owner

alanxz commented Mar 31, 2021

Thanks @FakeTeam for the contribution, and @evorw for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

where I can set the keyPassphrase of client_key when use ssl connect?
3 participants