ssl: use SSL_get1_peer_certificate() in OpenSSL 3 #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the failing CI build is unrelated to the changes in this PR |
The function SSL_get_peer_certificate() was deprecated in 3.0.0. Now it is defined as a compatibility macro to SSL_get1_peer_certificate(). However if your OpenSSL 3 is not compiled with the deprecated API included, rabbitmq-c will fail to compile. This commit adds an OpenSSL version check to use the appropriated function.
|
Presubmit should be fixed in #831. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
SSL_get_peer_certificate()was deprecated in 3.0.0. Now it is defined as a compatibility macro toSSL_get1_peer_certificate().However if your OpenSSL 3 is not compiled with the deprecated API included, rabbitmq-c will fail to compile. This commit adds an OpenSSL version check to use the appropriated function.