ci: add windows CI for nimskull

alaviss · Aug 31, 2024 · f714195 · f714195
1 parent f578b77
commit f714195
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -64,10 +64,12 @@ jobs:
           - target: macos
             arch: i386
 
-          # TODO: a handful of problems with SSL must be solved before this
+          # 32-bit OpenSSL is a pain, so skip
           - target: windows
+            arch: i386
             compiler:
               name: nimskull
+
     name:
       ${{ matrix.target }} on ${{ matrix.arch }} (${{ matrix.compiler.name }}
       ${{ matrix.compiler.version }})

diff --git a/src/sys/private/paths_windows.nim b/src/sys/private/paths_windows.nim
@@ -13,7 +13,7 @@ const
   ValidSeparatorsImpl = {SeparatorImpl, '/'}
 
 type
-  PathParseState = enum
+  PathParseState {.pure.} = enum
     Start
     MaybeRoot
     FoundPrefix
@@ -22,7 +22,7 @@ type
     AtRoot
     PathElement
 
-  PathState = enum
+  PathState {.pure.} = enum
     UncNeedHost
     UncNeedShare
     AtRoot
@@ -154,11 +154,11 @@ template joinImpl() {.dirty.} =
         else:
           discard "This is a DOS drive"
       of UncNeedShare:
-        state = AtRoot
-      of UncNeedHost, AtRoot:
+        state = PathState.AtRoot
+      of UncNeedHost, PathState.AtRoot:
         discard "These states cannot be reached from the start"
     of Root:
-      state = AtRoot
+      state = PathState.AtRoot
     else:
       state = Normal
       break
@@ -176,7 +176,7 @@ template joinImpl() {.dirty.} =
         discard "Nothing to do"
 
       of PreviousDir:
-        if state == AtRoot:
+        if state == PathState.AtRoot:
           continue
 
       else: