sockets: prototype for ipv6 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaviss
force-pushed
the
features/sockets-v6
branch
from
9c4dcec
to
b01bd74
Compare
alaviss
force-pushed
the
features/sockets-v6
branch
3 times, most recently
from
08d1822
to
b59cde6
Compare
alaviss
force-pushed
the
features/sockets-v6
branch
from
91ff4af
to
6491db2
Compare
alaviss
force-pushed
the
features/sockets-v6
branch
from
6491db2
to
6e75933
Compare
With the current prototype, I'm opting for keeping the transport protocol address family agnostic. This means that variants have to be used to distinguish between IPv4 and IPv6 addresses, but simplifies the typical usage of data transport drastically by not requiring strict type disambiguation. I might revisit making TCP4/TCP6 sockets a thing when a form of polymorphism exists for the language. Breaking changes: - resolveIP4 -> resolveIP - addressing APIs now return IPEndpoint, which could be either IP4 or IP6 endpoint
This fixes the bug regarding object variant usage
Nim stdlib definition is inconsistent between OS, so we fix it here.
NimSkull doesn't bode well with `.type`, switching to `type()` seems to work
For OS/Arch other than linux/amd64, these are importc-ed and cannot be used in static context. Switch to if to get them working.
It is now fixed
alaviss
force-pushed
the
features/sockets-v6
branch
from
6e75933
to
df43f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current prototype, I'm opting for keeping the transport protocol address family agnostic. This means that variants have to be used to distinguish between IPv4 and IPv6 addresses, but simplifies the typical usage of data transport drastically by not requiring strict type disambiguation.
I might revisit making TCP4/TCP6 sockets a thing when a form of polymorphism exists for the language.
Breaking changes:
Implementation status:
Blocked by: nim-works/cps#301Fixed with CPS 0.10.1