files, sockets: ignore cleanup exceptions on =destroy #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In these situations there are only two reasons why cleaning up fails: * The FD is invalid * There is something wrong with the OS The first case is already covered by Defects, which are not ignored, and we can't do anything (nor can the caller) for the latter, so just ignore those. This is brought on by nimskull 0.1.0-dev.21268, which disallows raise in hooks since that was undefined behavior.
alaviss
changed the title
For similar reasons to 5409323, any catchable exception here is benign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these situations there are only two reasons why cleaning up fails:
The first case is already covered by Defects, which are not ignored, and we can't do anything (nor can the caller) for the second case, so just ignore those.
This is brought on by nimskull 0.1.0-dev.21268, which disallows raise in hooks since that was undefined behavior.