Fixed windows incompatibility

manifest.json

@@ -1,7 +1,7 @@
 {
   "id": "import-attachments-plus",
   "name": "Import Attachments+",
-  "version": "1.2.6",
+  "version": "1.3.0",
   "minAppVersion": "1.5.0",
   "description": "Move and link the attachments into the vault.",
   "author": "Andrea Alberti",

src/ImportAttachmentsModal.ts

@@ -213,7 +213,7 @@ export class OverwriteChoiceModal extends Modal {
 		origFileLink.addEventListener('click', (e) => {
 			e.preventDefault(); // Prevent the default anchor behavior
 			// Open the folder in the system's default file explorer
-			window.require('electron').remote.shell.showItemInFolder(this.originalFilePath);
+			window.require('electron').remote.shell.showItemInFolder(Utils.makePosixPathOScompatible(this.originalFilePath));
 		});
 
 		paragraph.append(' into the vault. However, a ');
@@ -226,7 +226,7 @@ export class OverwriteChoiceModal extends Modal {
 		vaultFileLink.addEventListener('click', (e) => {
 			e.preventDefault(); // Prevent the default anchor behavior
 			// Open the folder in the system's default file explorer
-			window.require('electron').remote.shell.showItemInFolder(Utils.joinPaths(this.plugin.vaultPath,this.destFilePath));
+			window.require('electron').remote.shell.showItemInFolder(Utils.makePosixPathOScompatible(Utils.joinPaths(this.plugin.vaultPath,this.destFilePath)));
 		});
 
 		paragraph.append(' with the same name already exists at the destination location.');
@@ -309,7 +309,7 @@ export class DeleteAttachmentFolderModal extends Modal {
 				e.preventDefault(); // Prevent the default anchor behavior
 				// Open the folder in the system's default file explorer
 				// window.require('electron').remote.shell.showItemInFolder(this.attachmentFolderPath);
-				window.require('electron').remote.shell.openPath(Utils.joinPaths(this.plugin.vaultPath,this.attachmentFolderPath));
+				window.require('electron').remote.shell.openPath(Utils.makePosixPathOScompatible(Utils.joinPaths(this.plugin.vaultPath,this.attachmentFolderPath)));
 			});
 		} else {
 			paragraph.createEl('strong', {text: attachmentFolderPath_parsed.filename});
@@ -384,7 +384,7 @@ export class ImportFromVaultChoiceModal extends Modal {
 		fileLink.addEventListener('click', (e) => {
 			e.preventDefault(); // Prevent the default anchor behavior
 			// Open the folder in the system's default file explorer
-			window.require('electron').remote.shell.showItemInFolder(Utils.joinPaths(this.plugin.vaultPath,this.relativeFilePath));
+			window.require('electron').remote.shell.showItemInFolder(Utils.makePosixPathOScompatible(Utils.joinPaths(this.plugin.vaultPath,this.relativeFilePath)));
 		});
 
 		paragraph.append(' is already stored in the vault.');
@@ -482,7 +482,7 @@ export class FolderImportErrorModal extends Modal {
             fileLink.addEventListener('click', (e) => {
                 e.preventDefault(); // Prevent the default anchor behavior
                 // Open the folder in the system's default file explorer
-                window.require('electron').remote.shell.openPath(folder.path);
+                window.require('electron').remote.shell.openPath(Utils.makePosixPathOScompatible(folder.path));
             });
         });
 

src/main.ts

@@ -36,6 +36,8 @@ import {
 } from './types';
 import * as Utils from "utils";
 
+import { sep, posix } from 'path';
+
 import { promises as fs } from 'fs';  // This imports the promises API from fs
 
 import { patchOpenFile, unpatchOpenFile, addKeyListeners, removeKeyListeners } from 'patchOpenFile';
@@ -97,7 +99,8 @@ export default class ImportAttachments extends Plugin {
 			if (!(adapter instanceof FileSystemAdapter)) {
 				throw new Error("The vault folder could not be determined.");
 			}
-			this.vaultPath = adapter.getBasePath();
+			// Normalize to POSIX-style path
+			this.vaultPath = adapter.getBasePath().split(sep).join(posix.sep);
 		} else {
 			this.vaultPath = "";
 		}
@@ -919,9 +922,7 @@ export default class ImportAttachments extends Plugin {
 
 		// Open the folder in the system's default file explorer
 		// eslint-disable-next-line @typescript-eslint/no-var-requires
-		const { shell } = require('electron');
-		// window.require('electron').remote.shell.showItemInFolder(attachmentsFolder.attachmentsFolderPath);
-		shell.openPath(absAttachmentsFolderPath);
+		require('electron').remote.shell.openPath(Utils.makePosixPathOScompatible(absAttachmentsFolderPath));
 	}
 
 	// Function to insert links to the imported files in the editor

src/patchOpenFile.ts

@@ -6,7 +6,7 @@ let metaKeyPressed = false;
 let altKeyPressed = false;
 let keyListenersInstalled = false
 
-import { joinPaths } from 'utils';
+import { joinPaths, makePosixPathOScompatible } from 'utils';
 
 // Save a reference to the original method for the monkey patch
 let originalOpenFile: ((this: WorkspaceLeaf, file: TFile, openState?: OpenViewState)=> Promise<void>) | null = null;
@@ -108,7 +108,7 @@ function patchOpenFile(plugin: ImportAttachments) {
 		const newEmptyLeave = this.getViewState()?.type == 'empty';
 
 		if(plugin.settings.revealAttachment && metaKeyPressed && altKeyPressed){
-			window.require('electron').remote.shell.showItemInFolder(joinPaths(plugin.vaultPath,file.path));
+			window.require('electron').remote.shell.showItemInFolder(makePosixPathOScompatible(joinPaths(plugin.vaultPath,file.path)));
 		}
 		else if(plugin.settings.openAttachmentExternal && metaKeyPressed && !altKeyPressed) {
 			plugin.app.openWithDefaultApp(file.path);

src/utils.ts

@@ -45,6 +45,10 @@ export function arePathsSameFile(vault: Vault, filePath1: string, filePath2: str
 	return false;
 }
 
+export function makePosixPathOScompatible(posixPath:string): string {
+	return posixPath.split(path.posix.sep).join(path.sep);
+}
+
 export async function hashFile(filePath: string): Promise<string> {
 	const hash = crypto.createHash('md5');
 	let fileHandle = null;