-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr 1789 #1790
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new image transformation called PlanckianJitter, which simulates illumination changes based on temperature. The transformation uses Pydantic for input validation, ensuring that parameters are within specified ranges. Additionally, pre-commit fixes were applied to maintain code formatting standards. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
Here's what I looked at during the review
- 🔴 General issues: 2 blocking issues, 5 other issues
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Small fixes on top of #1789
@zakajd
As you wanted faster just refactored on top:
InitSchema
classP.S. All credit for the work goes to you.
Summary by Sourcery
This pull request introduces the PlanckianJitter transform for realistic color augmentation, adds Pydantic-based input validation for the new transform, and includes pre-commit fixes.