-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random gaussian blur #2144
Add random gaussian blur #2144
Conversation
Reviewer's Guide by SourceryThis PR adds a new RandomGaussianBlur transform class that serves as an alias for the existing GaussianBlur transform, providing compatibility with Kornia's API while maintaining the same functionality. The implementation includes parameter mapping between the two naming conventions and adds appropriate documentation and tests. Class diagram for the new RandomGaussianBlur transformclassDiagram
class RandomGaussianBlur {
- ScaleIntType kernel_size
- ScaleFloatType sigma
- bool|None always_apply
- float p
+ RandomGaussianBlur(ScaleIntType kernel_size, ScaleFloatType sigma, bool|None always_apply, float p)
+ get_transform_init_args_names() tuple[str, ...]
}
class GaussianBlur {
<<abstract>>
}
RandomGaussianBlur --|> GaussianBlur : Inherits
note for RandomGaussianBlur "This class is an alias for GaussianBlur with parameter naming for Kornia compatibility."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
=========================================
+ Coverage 0 90.37% +90.37%
=========================================
Files 0 48 +48
Lines 0 8045 +8045
=========================================
+ Hits 0 7271 +7271
- Misses 0 774 +774 ☔ View full report in Codecov by Sentry. |
Addresses: #2092
Summary by Sourcery
Add RandomGaussianBlur transform as an alias for GaussianBlur to ensure compatibility with Kornia API, refactor MotionBlur class, update documentation, and add a test case for the new transform.
New Features:
Enhancements:
Documentation:
Tests: