Update linters #831
Merged
Update linters #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow DeepSource suddenly reported 115 new issues. Most of them are not even relevant to the code changed in this PR. After a brief look, some of those issues look very disputable. I think we should disable DeepSource completely until someone is willing to resolve all those issues manually. This will help to reduce the excessive amount of warnings for contributors who create new PRs. |
Dipet
approved these changes
Jan 31, 2021
BloodAxe
approved these changes
Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check-yamlhook because there is no way to exclude certain YAML files from checking, and the linter produces warnings for theconda.recipe/meta.yamlfile, which is in fact not a YAML file but a Jinja template that generates a YAML file.keypointvariable insideperspective_keypoint(albumentations/augmentations/geometric/functional.py:382: error: Incompatible types in assignment (expression has type "ndarray", variable has type "Union[List[int], List[float]]"))