Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated IAAFliplr, IAAFlipud, IAAAdditiveGaussianNoise #844

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

Dipet
Copy link
Collaborator

@Dipet Dipet commented Feb 16, 2021

  • Added deprecation warnings to:
    • IAAFliplr
    • IAAFlipud
    • IAAAdditiveGaussianNoise
  • Added logic to check whole links and table to docs. It is needed to remove deprecated transforms from README.
  • Added per_channel flag to GaussNoise because it is exists in IAAAdditiveGaussianNoise
  • Fixed unserialized mean

@Dipet Dipet requested review from creafz, ternaus and BloodAxe and removed request for creafz and ternaus February 16, 2021 20:57
@creafz
Copy link
Contributor

creafz commented Feb 17, 2021

I propose two changes that could be either implemented in this PR or in a new PR:

  1. Use FutureWarning instead of DeprecationWarning for imgaug augmentations. DeprecationWarning is suppressed by default so most users won't see messages about deprecated augmentations.
  2. Explicitly name the augmentation in a warning. So use IAAFliplr is deprecated... instead of This augmentation is deprecated.... In that case, users will know which augmentation is causing problems without a need to dig into the source code.

@Dipet Dipet merged commit ba44eff into master Feb 24, 2021
@Dipet Dipet deleted the deprecate_iaa_flips_noise branch May 20, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants