Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the delay in re-opening this pull request. This would add only the following functionality to
rbac-tool gen
andrbac-tool show
commands. While the intent ofrbac-tool show
is not necessarily to generate clusterroles/roles, it made sense to include the flags both places since they call the samegenerateRole
function.This will also maintain the same default role names and namespace for users that are not passing the new flags.
Generate Role:
Output:
Generate ClusterRole:
rbac-tool gen \ --allowed-groups ,apps \ --name foo \ --annotations argocd.argoproj.io/sync-wave=2,rbac.authorization.kubernetes.io/autoupdate=true
Output:
Thanks again! 😄