Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (hidden) support for opening urls in tabs #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

errantmind
Copy link

@errantmind errantmind commented Feb 8, 2021

As it has been so long since this feature was requested, I figured I'd add simple support as a hidden feature, then @alct can style it in the UX at a later date if desired. This addresses #11

Flow:

  1. User pastes text containing urls into the text area
  2. User clicks the counter
  3. Tabs open

Note, I don't see any UX issues with this, aside from it being a hidden feature. When the tabs open, the textarea automatically updates with the correct list of urls again, so this simple addition 'just works'

@adamency
Copy link

adamency commented Dec 20, 2021

@alct Can you please just accept this PR ? I guess you don't have time to work on this project anymore, but it's a matter of 5 minutes to review the code and merge it, while it would add the most requested feature for this project. I would be extremely grateful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants