This repository has been archived by the owner on Apr 10, 2019. It is now read-only.
Split environment variable setup #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
suggested changes
Jul 12, 2017
main.go
Outdated
| for _, path := range paths { | ||
| if p == path { | ||
| if path == path { |
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
alecthomas
approved these changes
Jul 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variables are setup for two cases: run and install.
I believe that each case requires different variables. Run only requires
PATHto be set correctly. Install requiresGOBINandGOPATHto be set correctly.This change splits
configureEnvironment()into two functions. One for run, and one for "install vendored linters". This skips any unnecessaryos.Setenv()and makes it more obvious which variables are used for which case. Any overlap between these cases should still be shared using extracted functions.