Rename gas security checker to gosec #505
Conversation
|
Tests are not working. |
|
@alecthomas I had to rework a bit the test. cc @gcmurphy |
|
This should also fix issue reported in #499 (comment) |
regressiontests/gosec_test.go
Outdated
|
|
||
| func TestGosec(t *testing.T) { | ||
| t.Parallel() | ||
| gopath := os.Getenv("GOPATH") |
There was a problem hiding this comment.
Can you please change this to create a new GOPATH in a temporary directory? You can use gotest.tools/fs to do this fairly easily.
You might need to have a GOPATH with two entries - the existing one and the temporary one.
.goreleaser.yml
Outdated
| goos: *goos | ||
| goarch: *goarch | ||
| env: *env | ||
| main: ./_linters/src/github.com/GoASTScanner/gas | ||
| main: ./_linters/src/github.com/securego/gosec |
There was a problem hiding this comment.
Is this the main command target?
|
Thanks for this, I appreciate it. |
|
@alecthomas Thanks for your suggestion. I fixed the test code accordantly. |
|
Brilliant, thanks! |
| @@ -84,7 +84,7 @@ There are two options for installing gometalinter. | |||
| - [interfacer](https://github.com/mvdan/interfacer) - Suggest narrower interfaces that can be used. | |||
| - [unconvert](https://github.com/mdempsky/unconvert) - Detect redundant type conversions. | |||
| - [goconst](https://github.com/jgautheron/goconst) - Finds repeated strings that could be replaced by a constant. | |||
| - [gas](https://github.com/GoASTScanner/gas) - Inspects source code for security problems by scanning the Go AST. | |||
| - [goesc](https://github.com/securego/gosec) - Inspects source code for security problems by scanning the Go AST. | |||
There was a problem hiding this comment.
Thanks. I fixed it in #506
Guys changed linter name here alecthomas/gometalinter#505
* Rename gas to gosec Follows alecthomas/gometalinter#505
|
Could it be that this change breaks usage of I can still disable using |
|
This is a breaking change. We were running the linter with Could you please bump the major version to Tools like http://labix.org/gopkg.in are designed so that breaking changes have to go into major versions. |
|
This change is not yet part of a release. If you're concerned about breaking changes use a tag. |
cc @alecthomas