fix required/xor behavior w/ > 2 flags

alecthomas · Jan 29, 2022 · ab085f7 · ab085f7
1 parent e497001
commit ab085f7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/context.go b/context.go
@@ -793,8 +793,8 @@ func checkMissingFlags(flags []*Flag) error {
 			missing = append(missing, flag.Summary())
 		}
 	}
-	for _, flags := range xorGroup {
-		if len(flags) > 1 {
+	for xor, flags := range xorGroup {
+		if !xorGroupSet[xor] && len(flags) > 1 {
 			missing = append(missing, strings.Join(flags, " or "))
 		}
 	}

diff --git a/kong_test.go b/kong_test.go
@@ -932,6 +932,10 @@ func TestXorRequiredMany(t *testing.T) {
 	_, err := p.Parse([]string{"--one"})
 	require.NoError(t, err)
 
+	p = mustNew(t, &cli)
+	_, err = p.Parse([]string{"--three"})
+	require.NoError(t, err)
+
 	p = mustNew(t, &cli)
 	_, err = p.Parse([]string{})
 	require.EqualError(t, err, "missing flags: --one or --two or --three")