fix: existing file/dir always checks default #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alecthomas Friendly bump |
alecthomas
approved these changes
May 16, 2022
|
LGTM thanks! Mind rebasing and I'll merge? |
|
Pulled in changes, but looks like that introduced an unused import (and it looks like #305 is already intended to address). I'll wait for that PR to land, rebase, then we should be good! |
|
#305 is merged! |
pyqlsa
force-pushed
the
fix/existing-default-check
branch
from
7a9272b
to
e327cf3
Compare
updated existing file/dir mappers to early return if already set; added tests for existing file/dir mappers;
pyqlsa
force-pushed
the
fix/existing-default-check
branch
from
e327cf3
to
ba6fc72
Compare
|
Rebased, I'm GTG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated existing-file/dir mappers to early return if already set successfully, such that the default value is not checked if a user-provided value has already been verified successfully. This is intended to avoid failures when a default value does not exist and the user-provided value does, allowing for successful continuation.
Added tests for existing-file/dir mappers.
Intended to fix #26