Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help fails sometimes due to
kong.Parse()
callingcontext.go:Context.Reset()
early in the function; this call toContext.Reset()
makes subsequent calls tomodel.go:Value.Reset()
;Value.Reset()
callsParse
for environment variables and default values;Parse
in turn callsValue.Mapper.Decode()
, which executes the resolver; if the resolver fails, thenParse
fails duringReset
; originally,--help
was implemented as aBeforeApply
hook, but due to the above described call order, it wasn't getting called in some failure conditions; ifReset
is moved to a later stage inkong.Parse
, the hook can be called, allowing for usage to be printed.Initially opening as a draft, as there may be unintended consequences of moving
Reset
around inParse
and changing--help
to aBeforeResolve
hook.