Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EnvFlag util #378

Merged
merged 5 commits into from
Sep 16, 2023
Merged

Add EnvFlag util #378

merged 5 commits into from
Sep 16, 2023

Conversation

artemklevtsov
Copy link
Contributor

Hi,

This PR adds the EnvFlag util type to read env-files. Used BeforeReset hook and godotenv package to load file.

alecthomas
alecthomas reviewed Sep 16, 2023
View reviewed changes
Copy link
Owner

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate the PR, I don't think this needs to belong in the core of Kong, particularly as it adds another dependency. It might be a good addition to the README however, if you'd like to adjust the PR?

@artemklevtsov
Copy link
Contributor Author

I added snippet to the README.md.

@alecthomas alecthomas merged commit 1e6f15f into alecthomas:master Sep 16, 2023
2 checks passed
@alecthomas
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemklevtsov @alecthomas