Make negatable flag name customisable #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check for flags with the `negatable` option if the negative flag
conflicts with another tag, such as:
Flag bool `negatable:""`
NoFlag bool
The flag `--no-flag` is ambiguous in this scenario.
Allow a value on the `negatable` tag to specify a flag name to use for
negation instead of using `--no-<flag-name>` as the flag.
e.g.
Approve bool `default:"true",negatable:"deny"`
This example will allow `--deny` to set the `Approve` field to false.
alecthomas
approved these changes
Jul 24, 2024
| } | ||
|
|
||
| flagString += fmt.Sprintf("%s--%s", short, name) |
There was a problem hiding this comment.
Is this correct? Looks like it could give something like f--force
There was a problem hiding this comment.
short is either -X, (hyphen, flag, comma, space) , (four spaces) or "" (empty string). It is pre-formatted, not just the actual short flag. I could change the name from short to shortFmt or something if you prefer.
|
Thanks Cam, sorry about the delay this slipped my mind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a value on the
negatabletag to specify a flag name to use fornegation instead of using
--no-<flag-name>as the flag.e.g.
This example will allow
--denyto set theApprovefield to false.Add duplicate flag name detection for negatable flags.