More tests and fixes for gen lexer word boundary #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Third time's the charm! The correct word boundary test when the position is NOT at the beginning and NOT at the end is to always test the character before the current position and the character at the current position. In the first version, it tested the character at the current position and the next character after the current position. In the second version, it also tested the character before the current position and the character at the current position. The correct solution is simpler and makes sense. Added more conformance tests to cover the changes, including more cases to ensure \b does NOT match when it should not.
alecthomas
approved these changes
Oct 28, 2022
|
Awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third time's the charm!
The correct word boundary test when the position is NOT at the beginning and NOT at the end is to always test the character before the current position and the character at the current position.
In the first version, it tested the character at the current position and the next character after the current position.
In the second version, it also tested the character before the current position and the character at the current position.
The correct solution is simpler and makes sense.
Added more conformance tests to cover the changes, including more cases to ensure \b does NOT match when it should not.