Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date format support #234

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Date format support #234

merged 1 commit into from
Oct 25, 2016

Conversation

divanovGH
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Oct 24, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 94.473% when pulling e4db597 on divanovGH:master into 0853189 on alecthomas:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 95.204% when pulling d29e878 on divanovGH:master into 0853189 on alecthomas:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 24, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 95.204% when pulling d29e878 on divanovGH:master into 0853189 on alecthomas:master.

tusharmakkar08
tusharmakkar08 requested changes Oct 24, 2016
View reviewed changes
Copy link
Collaborator

@tusharmakkar08 tusharmakkar08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the changes requested.

voluptuous/tests/tests.py
@@ -745,3 +745,13 @@ def test_named_tuples_validate_as_tuples():
Schema((int, int))(t)
Schema(NT(int, int))(nt)
Schema(NT(int, int))(t)


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case where DateInvalid is catched ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is already written in the 760 line

voluptuous/validators.py
try:
datetime.datetime.strptime(v, self.format).date()
if len(v) != len(self.FORMAT_DESCRIPTION):
raise ValueError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ValueError doesn't provide sufficient information. Use DateInvalid with different string input.

@coveralls
Copy link

coveralls commented Oct 24, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.8%) to 95.816% when pulling 0fe64cd on divanovGH:master into 0853189 on alecthomas:master.

@coveralls
Copy link

coveralls commented Oct 24, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 95.918% when pulling ff06372 on divanovGH:master into 0853189 on alecthomas:master.

@tusharmakkar08
Copy link
Collaborator

This looks fine. Please squash your commits.

@coveralls
Copy link

coveralls commented Oct 25, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 95.918% when pulling 8833a97 on divanovGH:master into 0853189 on alecthomas:master.

@divanovGH
Copy link
Author

Done!

@tusharmakkar08 tusharmakkar08 merged commit c6080c7 into alecthomas:master Oct 25, 2016
This was referenced Apr 12, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
@pyup-bot pyup-bot mentioned this pull request Feb 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmakkar08 tusharmakkar08 tusharmakkar08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divanovGH @coveralls @tusharmakkar08