Remove unicode translation #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unicode translation added in commit added in 5e3bf14 heavily broke Python 2. A basic test such as provided in test_unicode_as_key in this patch does not work anymore because of that conversion. This patches goes back to the behaviour that was in 0.9.
|
@alecthomas @tusharmakkar08 if you could look into that quickly, that broke entirely some of our software in OpenStack :( |
This was referenced Apr 13, 2017
|
Hey @jd Please update voluptuous version to Thanks. |
This was referenced Apr 13, 2017
|
Thanks for the fast merge @tusharmakkar08 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicode translation added in commit added in
5e3bf14 heavily broke Python 2. A basic test
such as provided in test_unicode_as_key in this patch does not work anymore
because of that conversion.
This patches goes back to the behaviour that was in 0.9.